From: René Scharfe Date: Tue, 27 Jun 2023 16:21:57 GMT Subject: Re: [PATCH 2/5] strbuf: factor out strbuf_expand_step() Message-ID: <6fc5092d-2095-5b44-cc26-1e7208a342f0@web.de> In-Reply-To: <20230627082622.GH1226768@coredump.intra.peff.net> Am 27.06.23 um 10:26 schrieb Jeff King: > On Sat, Jun 17, 2023 at 10:41:44PM +0200, René Scharfe wrote: > >> Extract the part of strbuf_expand that finds the next placeholder into a >> new function. It allows to build parsers without callback functions and >> the overhead imposed by them. >> >> Signed-off-by: René Scharfe >> --- >> builtin/branch.c | 13 ++----------- >> strbuf.c | 28 ++++++++++++++-------------- >> strbuf.h | 8 ++++++++ >> 3 files changed, 24 insertions(+), 25 deletions(-) > > I was a little surprised to see the change in branch.c here (as well as > the one in strbuf_addftime), since the commit message just says > "extract..." and doesn't mention them. Fair point, the other extraction sources should have been mentioned as well somehow. > They do serve as examples of how it can be used, so I think it's OK. But > it made me wonder: is this all of the sites? Or are these just examples? These are all that I could find. René