From: Phillip Wood Date: Tue, 10 Aug 2021 15:24:07 GMT Subject: Re: [PATCH/RFC 3/3] ci: run a pedantic build as part of the GitHub workflow Message-ID: <6fac977d-80c5-d123-d232-2df5e5966c04@gmail.com> In-Reply-To: On 09/08/2021 23:48, Carlo Arenas wrote: > On Mon, Aug 9, 2021 at 7:56 AM Phillip Wood wrote: >> >> Totally unrelated to this patch but while looking at the ci scripts I >> noticed that we only run the linux-gcc-4.8 job on travis, not on github. > > it is actually related and part of the reason why I sent this as an RFC. > travis[1] itself is not running, probably because it broke when > travis-ci.org was > shutdown some time ago. > > maybe wasn't as useful as a CI job using valuable CPU minutes when it could > run in the development environment before the code was submitted? the same > could apply to this request if you consider that unlike the other > similar jobs (ex: sparse or "Static Analysis") > there is no need to install an additional (probably tricky to get tool) I think there is value in running the CI jobs with -Wpedantic otherwise we'll continually fixing patches up after they've been merged, I just wonder if we need a separate job to do it. We could export DEVOPTS=pedantic in ci/build-and-run-tests.sh or change config.mak.dev to turn on -Wpedantic with DEVELOPER=1. Having said all that your commit message also mentioned using a recent compiler to pick up any problem early, I'm not sure how common that is but perhaps that makes a new job worth it. If so there is a gcc docker image[1] which always has the latest compiler. Best Wishes Phillip [1] https://hub.docker.com/_/gcc > Carlo > > [1] https://travis-ci.com/github/git >