From: Mark Levedahl <mlevedahl@gmail.com>
Date: Tue, 02 Jun 2026 18:54:40 GMT
Subject: Re: [PATCH v3 00/12] Improve git gui operation without a worktree
Message-ID: <6f4276f9-cf0e-4840-88ce-9e0009c669a9@gmail.com>
In-Reply-To: <8515a482-9a08-4b0a-bd7c-385e1bda1a20@kdbg.org>



On 6/2/26 1:34 PM, Johannes Sixt wrote:
>>  2 files changed, 223 insertions(+), 175 deletions(-)
> This round looks excellent! Thank you very much!
>
> While queuing, I applied the small fixup below to 03/12.
>
> -- Hannes
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 933e72c9b255..15dd2b3a84cc 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -2064,7 +2064,6 @@ proc incr_font_size {font {amt 1}} {
>  
>  proc do_gitk {revs {is_submodule false}} {
>  	global current_diff_path file_states current_diff_side ui_index
> -	global _gitworktree
>  
>  	# -- Always start gitk through whatever we were loaded with.  This
>  	#    lets us bypass using shell process on Windows systems.
>

Oops, missed that. Thanks for catching.

You have duplicate signoffs on 02/12 in your repo.

Mark