From: Jakub Narębski Date: Wed, 05 Oct 2016 19:01:57 GMT Subject: Re: [PATCH v2 1/5] check_connected: accept an env argument Message-ID: <6ed4670d-6835-a45e-2842-cfe65b0e2981@gmail.com> In-Reply-To: <20161003204908.3nlg6xq2whg2senj@sigill.intra.peff.net> W dniu 03.10.2016 o 22:49, Jeff King pisze: > diff --git a/connected.h b/connected.h > index afa48cc..4ca325f 100644 > --- a/connected.h > +++ b/connected.h > @@ -33,6 +33,11 @@ struct check_connected_options { > > /* If non-zero, show progress as we traverse the objects. */ > int progress; > + > + /* > + * Insert these variables into the environment of the child process. > + */ > + const char **env; > }; Just a nitpick, but I wonder why one comment is in single-line form, and the other uses block-form with a single line. -- Jakub Narębski, bikeshedding