From: phillip.wood123@gmail.com
Date: Wed, 04 Sep 2024 14:35:35 GMT
Subject: Re: [PATCH v7 11/14] t/unit-tests: implement test driver
Message-ID: <6e941da7-cf7d-473c-bd32-56bebee6277f@gmail.com>
In-Reply-To: <ZthqtWVntB-PgSH-@pks.im>

Hi Patrick

On 04/09/2024 15:12, Patrick Steinhardt wrote:
> On Wed, Sep 04, 2024 at 02:35:20PM +0100, Phillip Wood wrote:
> Oh, that's a plain oversight on my side. It is easy to wire up given
> that the clar already supports it via "-Q". Also made me notice that I
> wrote "--immediate" instead of "immediate".

That's handy, I'd missed clar's "-Q" option.

>>> +		OPT_STRING_LIST('r', "run", &run_args, N_("name"),
>>> +				N_("run only test suite or individual test <name>")),
>>
>> It's nice that this option name now matches our integration tests. It would
>> be helpful to show the syntax for "name" (I think it expects
>> <suite>[::<test>]) but I failed to come up with a concise description to add
>> to the help here.
> 
> Isn't `<suite[::test]>` concise enough? I certainly like it.

Sounds good

Phillip

> Patrick