From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 18 May 2017 17:14:38 GMT
Subject: Re: [PATCH 00/23] Prepare to separate out a packed_ref_store
Message-ID: <6d84ff31-0282-00ec-83d6-9be2a8b7a776@kdbg.org>
In-Reply-To: <cover.1495014840.git.mhagger@alum.mit.edu>

Am 17.05.2017 um 14:05 schrieb Michael Haggerty:
> This patch series is the next leg on a journey towards reading
> `packed-refs` using `mmap()`, the most interesting aspect of which is
> that we will often be able to avoid having to read the whole
> `packed-refs` file if we only need a subset of references.

Which features of mmap() are you going to use? We have only MAP_PRIVATE 
on Windows. We do emulate PROT_WRITE (without PROT_READ), but I don't 
think that code is exercised anywhere. See also compat/win32mmap.c.

-- Hannes