From: Derrick Stolee Date: Thu, 13 Dec 2018 16:22:26 GMT Subject: Re: [PATCH v2 1/2] .gitattributes: ensure t/oid-info/* has eol=lf Message-ID: <6d6ca9a2-9245-e5e9-6d7a-e6d3004054bb@gmail.com> In-Reply-To: On 12/12/2018 9:38 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> From: Derrick Stolee >> >> The new test_oid machinery in the test library requires reading >> some information from t/oid-info/hash-info and t/oid-info/oid. >> The shell logic that reads from these files is sensitive to CRLF >> line endings, causing a problem when the test suite is run on a >> Windows machine that converts LF to CRLF. >> >> Exclude the files in this folder from this conversion. >> >> Signed-off-by: Derrick Stolee >> --- > It seems that this step is identical to v1, to which SZEDER Gábor > had trouble with (cf. <20181212133945.GV30222@szeder.dev>). I am > guessing that the review and v2 e-mails have crossed. > > FWIW, I personally do not think "is sensitive to CRLF" is too bad, > as my attempt to clarify it does not make it much better, e.g. > > The logic to read from these files in shell uses built-in > "read" command, which leaves CR at the end of these text > files when they are checked out with CRLF line endings, at > least when run with bash shipped with Git for Windows. This > results in an unexpected value in the variable these lines > are read into, leading the tests to fail. > > So, I'll keep what I queued when I received v1 for now. Sorry for missing the edit to the message. You are correct that v2 just added one commit. I like your rewording, if you feel like editing it. Thanks, -Stolee