From: Dragan Simic Date: Tue, 12 Sep 2023 17:48:59 GMT Subject: Re: [PATCH] diff --stat: add config option to limit filename width Message-ID: <6d286618ef9ad3824c4c40211557bfe7@manjaro.org> In-Reply-To: On 2023-09-12 19:11, Junio C Hamano wrote: > Dragan Simic writes: > >>> Someday, as a follow-up after the dust from this topic settles, we >>> would probably want to look at how these rev.diffopt.* members are >>> initialized and refactor the common code out to a helper. It would >>> allow us to instead of doing this ... >> >> Another good point. If you agree, I'd prefer to have my patch >> accepted and merged as-is, ... > > That is exactly what I meant by "follow-up after the dust settles". > > All of the "we should probably do this and that in the future" are > called #leftoverbits comments. Food for thought, something people > can use to find inspiration for areas they may want to work on, that > has no impact to how "complete" the current patch being discussed > is. Sounds great, thank you. I already have a couple of code cleanups to work on, which I'll do in the following days and send the patches.