From: Garima Singh <garimasigit@gmail.com>
Date: Mon, 13 Jan 2020 19:48:04 GMT
Subject: Re: [PATCH 2/9] commit-graph: write changed paths bloom filters
Message-ID: <6cefadde-7171-e081-ba5b-ba2543d9f22f@gmail.com>
In-Reply-To: <86eewczapt.fsf@gmail.com>


On 1/6/2020 1:44 PM, Jakub Narebski wrote:

> "Garima Singh via GitGitGadget" <gitgitgadget@gmail.com> writes: 
>> 3. The filters are sized according to the number of changes in the each commit,
>>    with minimum size of one 64 bit word.
> 
> Do I understand it correctly that the size of filter is 10*(number of
> changed files) bits, rounded up to nearest multiple of 64?
>

Yes.
  
>> +
>> +struct pathmap_hash_entry {
>> +    struct hashmap_entry entry;
>> +    const char path[FLEX_ARRAY];
>> +};
> 
> Hmmm... I wonder why use hashmap and not string_list.  This is for
> adding path with leading directories to the Bloom filter, isn't it?
> 

Yes. We do not want to repeat directories in the filter.

Thanks!
Garima Singh