From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Sat, 14 Oct 2023 19:37:08 GMT
Subject: Re: Bug: git grep --no-index 123 /dev/stdin crashes with SIGABRT
Message-ID: <6bb48aac-460c-4d7f-9057-40c3df0c807d@app.fastmail.com>
In-Reply-To: <2d8eca81-0415-43bf-b3c4-f1163713422b@app.fastmail.com>

On Sat, Oct 14, 2023, at 20:12, Kristoffer Haugsbakk wrote:
> It looks like `setup.c:verify_filename` fails to deny paths that are not
> transitive children (or whatever the term) of the directory that git(1) is
> running in:

No, that's not it. I don't think that's the responsibility of that
function. Compare to a successful run, that is when run in a Git
repository:

    $ git grep --no-index dfddf /home
    fatal: /home: '/home' is outside repository at '/home/kristoffer/programming/git'

And that error happens at `pathspec.c:473`.

So going down into that file is not wrong.