From: Kristoffer Haugsbakk Date: Fri, 02 Jun 2023 10:09:11 GMT Subject: Re: [PATCH v2] notes: update documentation for `use_default_notes` Message-ID: <6b7ead0c-97e5-430a-8034-ad870c9b2699@app.fastmail.com> In-Reply-To: <20230601175218.GB4165405@coredump.intra.peff.net> Hi Peff On Thu, Jun 1, 2023, at 19:52, Jeff King wrote: > This looks good to me. Arguably these should be documented in the > definition of "struct display_notes_opt", which would have avoided the > problem (3a03cf6b1d would not have forgotten to update the name since it > would be right there already). But it may not be worth the trouble to > move them now. Sounds like a good change to me. I’ll make a new version tomorrow unless someone disagrees about that before that time. -- Kristoffer Haugsbakk