From: Beat Bolli Date: Fri, 26 Aug 2016 20:27:29 GMT Subject: Re: [PATCH 1/2] gitk: align the commit summary format to the documentation Message-ID: <6afee090-fbe1-5d05-1f7e-6f0fc4901418@drbeat.li> In-Reply-To: On 26.08.16 21:16, Stefan Beller wrote: > On Fri, Aug 26, 2016 at 11:24 AM, Junio C Hamano wrote: >> Beat Bolli writes: >> >>> In 175d38c (SubmittingPatches: document how to reference previous commits, >>> 2016-07-28) the format for referring to older commits was specified. >>> >>> Make the text generated by the "Copy commit summary" command match this >>> format. >> >> Hmph. I didn't know gitk already had its own command to produce a >> short string. I actually think what it produces > > It was added in d835dbb91fe (gitk: Add a "Copy commit summary" command, > 2015-07-18), it doesn't seem to be in your tree yet, so maybe wait > with this patch > until you pulled gitk? This commit was part of release 2.6.0. >>> In 175d38c ("SubmittingPatches: document how to reference previous commits", >>> 2016-07-28) the format for referring to older commits was specified. >> >> is easier to read when pasted into a sentence than what the recent >> update 175d38ca ("SubmittingPatches: document how to reference >> previous commits", 2016-07-28) suggests to do, i.e. >> >>> In 175d38c (SubmittingPatches: document how to reference previous commits, >>> 2016-07-28) the format for referring to older commits was specified. >> >> Heiko, Stefan, I think you two were involved in adding that new >> paragraph. What do you think? > > So the subtle difference is adding '"' around the commit message subject? > > I agree we should fix that. So would you prepare a amendment to your documentation commit so that Junio can disregard my two patches? Thanks, Beat