From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 19 Aug 2019 16:12:32 GMT
Subject: Re: [RFC PATCH 0/5] line-log: towards a more responsive, incremental 'git log -L'
Message-ID: <6a576e13-79e6-43be-c4a8-065e7a8310ea@gmail.com>
In-Reply-To: <20190819150245.GV20404@szeder.dev>

On 8/19/2019 11:02 AM, SZEDER Gábor wrote:
> On Mon, Aug 19, 2019 at 10:50:48AM -0400, Derrick Stolee wrote:
>> Note that I don't include the "without patch" numbers. For some
>> reason the path provided is particularly nasty and caused 20,000+
>> missing blobs to be downloaded one-by-one (remember: VFS for Git
>> has many partial-clone-like behaviors). I canceled my test after 55
>> minutes. I'll dig in more to see what is going on, since only 37
>> commits actually change that path.
> 
> Don't bother digging into it, I know why it happens (and how to avoid
> it! :), but don't have the time right now to explain.

Great!  I look forward to your explanation and fix later.

Just to be sure we've got the same issue, here is a section of the
call stack in the hot portion:

line_log_filter
+ queue_diffs
  + diffcore_std
    + diffcore_rename
      + diff_populate_filespec

Thanks,
-Stolee