From: Benoit Sigoure <tsuna@lrde.epita.fr>
Date: Fri, 09 Nov 2007 07:57:00 GMT
Subject: Re: [BUG] git-rebase fails when a commit message contains a diff
Message-ID: <6FCE17E3-9FAA-4676-B12A-369B31743DA6@lrde.epita.fr>
In-Reply-To: <Pine.LNX.4.64.0711090225110.4362@racer.site>

On Nov 9, 2007, at 3:28 AM, Johannes Schindelin wrote:

> Would that not be easier to read as
>
> 		test t = "$INTERACTIVE" &&
> 			git_editor "$TODO" || die "Could not execute editor"

Hmm this will `die' if you're not running interactively.

Off topic question: why do you guys always do this instead of doing,  
say, this:

INTERACTIVE=false

case $1 in
.
.
.
   --interactive|-i)
     INTERACTIVE=:
     ... ;;
esac
.
.
.
if $INTERACTIVE; then
   git_editor "$TODO" || die ...
fi


?

-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory