From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Thu, 05 May 2011 06:57:20 GMT
Subject: Re: t5541: Bad file descriptor
Message-ID: <6F83A7A8-F4D7-4E1B-B6F4-03AE004C5726@gernhardtsoftware.com>
In-Reply-To: <20110505061845.GC29033@sigill.intra.peff.net>


On May 5, 2011, at 2:18 AM, Jeff King wrote:

> OK, embarrassing. 09c9957 completely breaks smart http pushing. My
> testing of Johannes' patch was completely focused on the error case, and
> I didn't have a single test for the non-error case. And on top of that,
> we _have_ nice tests in the test suite to catch this, but obviously
> neither I, nor Johannes, nor Junio were running them (because they need
> apache installed and GIT_TEST_HTTPD set).
> 
> Ugh.
> 
> This patch on top of 09c9957 should fix it.
> 
> -- >8 --
> Subject: [PATCH] send-pack: unbreak push over stateless rpc

While I could not get the patch to apply as-is (git apply complained of trailing whitespace), I performed the changes by hand and t5541 passed once more.

~~ Brian