From: Steffen Prohaska <prohaska@zib.de>
Date: Wed, 02 Jul 2008 17:20:25 GMT
Subject: Re: [PATCH 11/12] verify_path(): do not allow absolute paths
Message-ID: <6F445BD9-CE59-435A-AAF3-F380A7BCE29E@zib.de>
In-Reply-To: <alpine.DEB.1.00.0807021713290.9925@racer>



On Jul 2, 2008, at 6:15 PM, Johannes Schindelin wrote:

> Hi,
>
> On Wed, 2 Jul 2008, Junio C Hamano wrote:
>
>> Steffen Prohaska <prohaska@zib.de> writes:
>>
>>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>>> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
>>
>> No commit log message?  Justification?
>
> Justification: adding absolute paths was not caught properly on  
> Windows,
> and this was the easiest patch.
>
> However, IIRC, in the meantime we are nice to the user, and allow  
> absolute
> paths (which we turn into a relative path, or error out if it is not  
> under
> the current working directory).
>
> Steffen, can you revert the patch and verify that my memory does not  
> fail
> me?

Is

    git add /c/msysgit/git/read-cache.c

an appropriate test?

It fails with

    error: 'c:/msysgit/git/read-cache.c' is outside repository

no matter if the commit is reverted or not.

	Steffen