From: Philip Oakley Date: Mon, 23 Feb 2015 19:45:30 GMT Subject: Re: [PATCH 1/4] parse-options: introduce OPT_PATH Message-ID: <6D98922D49BD42139185BE6A94DDD5DA@PhilipOakley> In-Reply-To: From: "Michael J Gruber" > Many options are paths, but not files. Introduce OPT_PATH which does > the same path processing as OPT_FILENAME but allows to name the > argument. > > Signed-off-by: Michael J Gruber > --- > Documentation/technical/api-parse-options.txt | 5 +++++ > parse-options.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/Documentation/technical/api-parse-options.txt > b/Documentation/technical/api-parse-options.txt > index 1f2db31..109903c 100644 > --- a/Documentation/technical/api-parse-options.txt > +++ b/Documentation/technical/api-parse-options.txt > @@ -187,6 +187,11 @@ There are some macros to easily define options: > The filename will be prefixed by passing the filename along with > the prefix argument of `parse_options()` to `prefix_filename()`. > > +`OPT_PATH(short, long, &var, arg_str, description)`:: > + Introduce an option with a path argument named arg_str. > + The filename will be prefixed by passing the filename along with I couldn't understand this. Should it be s/filename/pathname/ ? Or am I way off topic. > + the prefix argument of `parse_options()` to `prefix_filename()`. > + > `OPT_ARGUMENT(long, description)`:: > Introduce a long-option argument that will be kept in `argv[]`. > > diff --git a/parse-options.h b/parse-options.h > index 7940bc7..5127a5d 100644 > --- a/parse-options.h > +++ b/parse-options.h > @@ -149,6 +149,8 @@ struct option { > PARSE_OPT_NOARG | PARSE_OPT_NONEG, (f) } > #define OPT_FILENAME(s, l, v, h) { OPTION_FILENAME, (s), (l), (v), > \ > N_("file"), (h) } > +#define OPT_PATH(s, l, v, a, h) { OPTION_FILENAME, (s), (l), (v), > \ > + (a), (h) } > #define OPT_COLOR_FLAG(s, l, v, h) \ > { OPTION_CALLBACK, (s), (l), (v), N_("when"), (h), PARSE_OPT_OPTARG, > \ > parse_opt_color_flag_cb, (intptr_t)"always" } > -- > 2.3.0.296.g32c87e1 > > -- Philip