From: Wincent Colaiuta <win@wincent.com>
Date: Sat, 08 Dec 2007 12:51:43 GMT
Subject: Re: [PATCH 4/4] Add tests for pre-commit and commit-msg hooks
Message-ID: <6C67E7B0-EE28-450C-A33F-35D3F742F495@wincent.com>
In-Reply-To: <1197116987-21802-1-git-send-email-win@wincent.com>

El 8/12/2007, a las 13:29, Wincent Colaiuta escribió:

> As desired, these pass for git-commit.sh, fail for builtin-commit  
> (prior
> to the fixes), and succeeded for builtin-commit (after the fixes).

Actually, that's a slight lie.

The commit-msg tests 9 and 10 (editing the commit message from the  
hook) fail for git-commit.sh (tested 1.5.3.4 and 1.5.3.7).

By the looks of it, this discrepancy isn't actually a bug in git- 
commit.sh, but is because of stuff that was in commit.c back in  
1.5.3.7 and prior which causes a commit message like "foo" to yield  
"foo<unknown>" when you do a "git log --pretty=format:%s%b -1"; post  
1.5.3.7 (on master) it instead yields "foo", which is what I was  
testing for.

Cheers,
Wincent