From: James Denholm Date: Mon, 05 May 2014 21:54:30 GMT Subject: Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass Message-ID: <69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com> In-Reply-To: <20140505050803.GA6569@sigill.intra.peff.net> On 5 May 2014 15:08:04 GMT+10:00, Jeff King wrote: >On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote: > >> The main issues are that calls are made to git itself in the build >> process, and that a subtree-exclusive variable is used for specifying >> the exec path. Patches 1/5 through 3/5 resolve these. >> >> The "cleanup" fixes (4/5 and 5/5) are based on precedents set by >other >> makefiles across the project. > >Thanks, these all look sane to me (I do not use subtree, but since it's >just about Makefiles, it was pretty easy to review). Thanks for the review! Given that subtree subtree doesn't really generate a lot of discussion, would it be advisable to wrap this up (barring further discussion) and send it off to Junio rather than waiting for further community consensus? Regards, James Denholm.