From: Lanny Ripple Date: Thu, 31 May 2012 17:49:16 GMT Subject: Re: Bug: rebase when an author uses accents in name on MacOSx Message-ID: <69ED148F-BD10-4DE3-91F2-D31F83A0EAB7@spotinfluence.com> In-Reply-To: <7vtxyw6ypx.fsf@alter.siamese.dyndns.org> Perhaps the error message in git-am could be modified to indicate sed is a suspect?. E.g., lanny(master); git rebase master rl-clean292 First, rewinding head to replay your work on top of it... /sw/lib/git-core/git-am: line 692: Leblond: command not found Patch does not have a valid e-mail address. (Used /sw/bin/sed found on PATH). ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ lanny((ae6c220...)|REBASE); Alternately in git-am a comment at the error emit point explaining that third-party seds are often the problem for this error and a suggestion to modify the PATH so the platform sed occurs first. Regards, -ljr --- Lanny Ripple lanny@spotinfluence.com On May 31, 2012, at 12:34 PM, Junio C Hamano wrote: > Lanny Ripple writes: > >> Bingo. >> >> lanny;~> echo "Rémi Leblond" | LANG=C LC_ALL=C /usr/bin/sed -ne 's/.*/GIT_AUTHOR_NAME='\''&'\''/p' >> GIT_AUTHOR_NAME='Rémi Leblond' >> >> Just occurred to me that I'm using fink and that git-am doesn't use /usr/bin/sed but just sed. My suggestion is to be explicit on the path in git-am. >> >> So it now stands at two bug-reports and one pebkac. > > My impression from reading the older thread Peff mentioned is that > the other ones are also broken implementation of sed supplied by > third-party, so it probably is not two Xs and one Y. It is three > something.