From: Andrei Rybak Date: Tue, 15 Jun 2021 23:28:33 GMT Subject: [BUG] range expressions in GIT_SKIP_TESTS are broken in master (was [BUG] question mark in GIT_SKIP_TESTS is broken in master) Message-ID: <6980e906-8076-1436-ecdb-6775eff55d39@gmail.com> In-Reply-To: <1d003cac-83fa-0b63-f60e-55513ac45cf9@gmail.com> On 15/06/2021 22:55, Andrei Rybak wrote: > Hi, > > I've taken an example of how to use GIT_SKIP_TESTS directly from > t/README: > >     $ GIT_SKIP_TESTS='t[0-4]??? t91?? t9200.8' make > > and noticed that t0000 is still being run.  I've written a script to > bisect the issue: > > >     #/bin/sh > >     ( >             cd t >             GIT_SKIP_TESTS='t[0-4]??? t91?? t9200.8' make | \ >                     head | grep 'SKIP skip all tests in t0000' >     ) > > > and it bisected to edc23840b0 (test-lib: bring $remove_trash out of > retirement, 2021-05-10) which was merged to master in 2019256717 ("Merge > branch 'ab/test-lib-updates'", 2021-06-14). > > Note, that spelling out the tests number in full works, i.e. > >     $ GIT_SKIP_TESTS=t0000 make > > won't run t0000. I sent this originally with incorrect subject. Question marks, e.g. $ GIT_SKIP_TESTS='t000?' make work. It is the range expressions, like [0-9] that are broken: $ GIT_SKIP_TESTS='t[0-9]000' make