From: Michael Strawbridge Date: Fri, 20 Oct 2023 21:06:36 GMT Subject: Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address" Message-ID: <68d7e5c3-6b4a-4d0d-9885-f3d4e2199f26@amd.com> In-Reply-To: <20231020100442.an47wwsti2d4zeyx@pengutronix.de> On 10/20/23 06:04, Uwe Kleine-König wrote: > hello, > > On Fri, Oct 13, 2023 at 04:14:37PM +0200, Uwe Kleine-König wrote: >> Hello, >> >> $ git send-email --to 'A B , C D ' lala.patch >> Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172. >> error: unable to extract a valid address from: >> >> This happens for me with git 2.42.0 and also on master (59167d7d09fd, "The seventeenth batch"). >> >> Bisection points at >> >> a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook") >> >> I didn't try to understand that change and fix the problem. > > Another (similar?) problem with non-ascii-chars: > > $ git send-email --to 'Will Deacon ' --to 'Krzysztof Wilczyński ' --to 'Lorenzo Pieralisi ' --cc 'Rob Herring ' --to 'Bjorn Helgaas ' --cc 'linux-pci@vger.kernel.org' --cc kernel@pengutronix.de -1 --base=@~ > Use of uninitialized value $address in sprintf at /home/uwe/gsrc/git/git-send-email line 1162. > error: unable to extract a valid address from: > > Bisection points to the same commit, when dropping ń in Krzysztof's > name, it works fine. > This is interesting. Thanks for reporting it. If you are able, could you please try the patches found in the below threads: - https://public-inbox.org/git/20230918212004.GC2163162@coredump.intra.peff.net/T/#mae64003cbb72f015bf5c0c04216524fcb6bb8d09 - https://public-inbox.org/git/f5c6a72b-f888-4d43-8be8-3ce2c878c669@gmail.com/T/#mca12dc95ccfd3ce2b94e7752ebaae9891201084f Thanks, Michael > Best regards > Uwe >