From: Johannes Sixt Date: Thu, 27 Oct 2016 06:10:24 GMT Subject: Re: [PATCH] compat: Allow static initializer for pthreads on Windows Message-ID: <67e38b43-0264-12f2-cca8-4b718ed7dc9d@kdbg.org> In-Reply-To: Am 27.10.2016 um 08:02 schrieb Junio C Hamano: > Johannes Sixt writes: > >> Am 26.10.2016 um 23:57 schrieb Stefan Beller: >>> In Windows it is not possible to have a static initialized mutex as of >>> now, but that seems to be painful for the upcoming refactoring of the >>> attribute subsystem, as we have no good place to put the initialization >>> of the attr global lock. >> >> Please rewrite the attribute system such that it can have a dynamic >> initialization. If you find a global initialization in main() too >> gross (I would agree) then setup_git_directory() might be the right >> place. > > As many codepaths may not even need access to the attributes, I > doubt that would be a very productive direction to go. So, what is productive then? Pessimizing one (not exactly minor) platform? -- Hannes