From: Johannes Schindelin via GitGitGadget Date: Wed, 15 Jun 2022 23:35:35 GMT Subject: [PATCH 01/11] mingw: avoid accessing uninitialized memory in `is_executable()` Message-ID: <679ea7421f73ce41515aca549982233f88bcefef.1655336146.git.gitgitgadget@gmail.com> In-Reply-To: From: Johannes Schindelin On Windows, we open files we suspect might be scripts, read the first two bytes, and see whether they indicate a hash-bang line. We do not initialize the byte _after_ those two bytes, therefore `strcmp()` is inappropriate here. Reported by Coverity. Signed-off-by: Johannes Schindelin --- run-command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run-command.c b/run-command.c index 14f17830f51..2ba38850b4d 100644 --- a/run-command.c +++ b/run-command.c @@ -154,7 +154,7 @@ int is_executable(const char *name) n = read(fd, buf, 2); if (n == 2) /* look for a she-bang */ - if (!strcmp(buf, "#!")) + if (!memcmp(buf, "#!", 2)) st.st_mode |= S_IXUSR; close(fd); } -- gitgitgadget