From: Phillip Wood Date: Tue, 15 Oct 2024 14:10:02 GMT Subject: Re: [PATCH v6 3/6] set-head: better output for --auto Message-ID: <65dd8e08-d8b2-4abb-a141-002d8f0b0401@gmail.com> In-Reply-To: On 15/10/2024 08:51, karthik nayak wrote: > "Bence Ferdinandy" writes: >> On Fri Oct 11, 2024 at 22:43, karthik nayak wrote: >>> "Bence Ferdinandy" writes: >>> I mean simply this >>> >>> git remote set-head --auto origin >output && >>> echo "${SQ}origin/HEAD${SQ} is now created and points to >>> ${SQ}main${SQ}" >expect && >> >> Ah, I see in other tests this is used, but not in this particular test file. >> It's a bit hard to decide which is more cryptic, but ${SQ} is nicer on the >> eyes. On the other hand I would either switch the entire file in a separate >> patch or leave in the '\'' here as well. Or I guess one could go through the >> entire test base and switch everything to either one or the other for >> consistency. > > I'm not sure I entirely agree with this sentiment. Consistency is a > great goal to target, but it shouldn't hinder changes that are > beneficial. Exactly - if we wait for an entire test file to be modernized before using our modern test idioms in it we'll be waiting forever. It is much better to introduce the use of things like ${SQ} that improve readability as we add new tests or modify existing ones. Best Wishes Phillip In our case, if you make the first change, there is now > reason for upcoming changes to the same file to also use '${SQ}' and > eventually we can reach consistency of using '${SQ}' throughout the file. > > - Karthik