From: Derrick Stolee <derrickstolee@github.com>
Date: Wed, 09 Mar 2022 18:42:32 GMT
Subject: Re: [PATCH v2 25/27] t/lib-unicode-nfc-nfd: helper prereqs for testing unicode nfc/nfd
Message-ID: <6555f3dc-e72c-2b0f-fe66-d81d48dff6f7@github.com>
In-Reply-To: <af6c456a-d49f-e0f2-50ae-f44fdb6351e3@github.com>

On 3/9/2022 1:40 PM, Derrick Stolee wrote:
> On 3/8/2022 5:15 PM, Jeff Hostetler via GitGitGadget wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Create a set of prereqs to help understand how file names
>> are handled by the filesystem when they contain NFC and NFD
>> Unicode characters.
> 
> Prereqs look good and are well documented.
> 
>> +if test $unicode_debug = 1
> 
> Is this $unicode_debug something I should know from a previous
> patch? or is it a leftover from local debugging?

I see that you set unicode_debug = 0 in a later patch, but I
suppose that we might want this output no matter what. Or, do
we think it will interrupt the output parsing of 'prove' and
other tools?

Thanks,
-Stolee