From: Phillip Wood Date: Tue, 08 Nov 2022 14:49:27 GMT Subject: Re: ab/cmake-nix-and-ci (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Message-ID: <64b91b29-bbcd-e946-1f20-c0a5be63d9b7@dunelm.org.uk> In-Reply-To: <221108.86cz9xsf1w.gmgdl@evledraar.gmail.com> On 08/11/2022 14:14, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Nov 03 2022, Taylor Blau wrote: > >> * ab/cmake-nix-and-ci (2022-11-02) 12 commits >> - CI: add a "linux-cmake-test" to run cmake & ctest on linux >> - cmake: copy over git-p4.py for t983[56] perforce test >> - cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults >> - Makefile + cmake: use environment, not GIT-BUILD-DIR >> - test-lib.sh: support a "GIT_TEST_BUILD_DIR" >> - cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh >> - cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable >> - cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4 >> - cmake: don't copy chainlint.pl to build directory >> - cmake: update instructions for portable CMakeLists.txt >> - cmake: don't "mkdir -p" and "cd" in build instructions >> - cmake: increase test timeout on Windows only >> >> Fix assorted issues with CTest on *nix machines. >> >> Waiting for review. >> source: > > I think the v4[1] you've since picked up should be ready, and I think > addressed the outstanding comments, except as noted in "let's pursue > that separately" in [2]. I think we need to wait for someone with windows experience to look at this as that is the primary use of the cmake build. Without that I think patches 4(?), 5 and 7 are still could go forward as a separate series but the rest of the patches including the documentation and test changes need to have buy-in from their primary audience. Best Wishes Phillip > 1. https://lore.kernel.org/git/cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com/ > 2. https://lore.kernel.org/git/221103.86a6581129.gmgdl@evledraar.gmail.com/