From: Mark Struberg Date: Fri, 04 Sep 2009 07:12:15 GMT Subject: Re: [JGIT] Request for help Message-ID: <64897.80194.qm@web27807.mail.ukl.yahoo.com> Hi! Since I work on the sonatype repo and also being a maven guy, I'd be happy to help! There are a few patches from the work we've done to come the next weeks anyway, starting with IgnoreRules and stuff. I think we still have to improve the code quality of SimpleRepository but I'd be happy to hear your opinion on this too, so I maybe send a RFC. If you like to go with maven for JGIT, we have 2 options: 1.) Use the current directory structure and use the configuration you can see in the sonatype poms Jason did. E.g all paths have to be set in pom.sml 2.) Do a complete rework and move over to the standard maven layout [1] . This may include moving org.spearce.jgit.test/ to org.spearce.jgit/src/test/java resp org.spearce.jgit/src/test/resources. In the meantime Eclipse is really fine with handling separate target folders for production code and test classes (target/classes vs target/test-classes) so this is not a showstopper any more. LieGrue, strub [1] http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html --- On Thu, 9/3/09, Shawn O. Pearce wrote: > From: Shawn O. Pearce > Subject: Re: [JGIT] Request for help > To: "Jonas Fonseca" > Cc: "Johannes Schindelin" , "Nasser Grainawi" , "Git Mailing List" > Date: Thursday, September 3, 2009, 5:52 PM > Jonas Fonseca > wrote: > > On Thu, Sep 3, 2009 at 10:42, Shawn O. Pearce > wrote: > > > Actually, now that we have forked out of the > egit.git repository, > > > I want to refactor the layout of the JGit project > to be more maven > > > like, and have a proper top-level pom to build > things. > > > > What kind of module structure do you have in mind? Do > you want to move > > some of the modules/subdirectories? > > Some refactoring of the maven setup for JGit back was > done back in > > April in sonatype's (a maven company) JGit clone. It > is not > > signed-off, but can serve as a reference. > > Yea, I was hoping they would contribute this back as > patches, > but thus far they haven't. >  > > The Maven layout in the sonatype clone simply uses the > Eclipse project layout. > > > > pom.xml: JGit :: Parent > >  |- org.spearce.jgit/pom.xml: JGit :: Core > >  |- org.spearce.jgit.pgm/pom.xml: JGit :: > Programs > >  `- org.spearce.jgit.test/pom.xml: JGit :: Test > > > > However, having tests in a separate module can be both > good/bad. For > > example, they will not automatically get run when you > only build the > > Core module. > > Yea, I know.  This is one area where Maven is just > whack, by putting > the tests in the same project the Maven plugin for Eclipse > puts > them into the same classpath, which means you can see test > code > from project code.  Wrong.  They should be > different projects so > the test classpath is isolated. > > However.  This is a bug in the Eclipse plugin I think, > not > necessarily with Maven's approach of trying to keep tests > alongside > the code they test.  Thus we probably want: > >   pom.xml: JGit :: Parent >    |- jgit-lib/pom.xml: JGit >    |  >    src/main/java  <-- from > org.spearce.jgit/src >    |  >    src/test/java  <-- from > org.spearce.jgit.test/src >    | >    `- jgit-pgm/pom.xml: JGit pgm >          src/main/java  > <-- from org.spearce.jgit.pgm/src > > IIRC there is Maven support to create proper MANIFEST.MF > files for > OSGI bundles, which is what we need for the Eclipse plugin > support. > That should be able to replace the META-INF/MANIFEST.MF in > the top > of each of the current directories. > > > Anyway, I would like to help. > > Please post patches; formatted with -M.  I do want to > do this, I just > don't have the patience and Maven-fu to write the new poms > myself. > > -- > Shawn. > -- > To unsubscribe from this list: send the line "unsubscribe > git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html >