From: Felipe Contreras Date: Mon, 24 Apr 2023 13:52:12 GMT Subject: Re: [PATCH] completion: suppress unwanted unescaping of `read` Message-ID: <6446898cd2dc3_aba294be@chronos.notmuch> In-Reply-To: <20230420223800.1698197-1-myoga.murase@gmail.com> Koichi Murase wrote: > From: Edwin Kofler > > The function `__git_eread`, which reads the first line from the file, > calls the `read` builtin without passing the flag option `-r`. When > the `read` builtin is called without the flag `-r`, it processes the > backslash escaping in the text that it reads. For this reason, it is > generally considered the best practice to always use the `read` > builtin with flag `-r` unless one intensionally processes the > backslash escaping. For the present case in git-prompt.sh, in fact, > all the occurrences of the calls of `__git_eread` intend to read the > literal content of the first lines. This is my undrstanding. I agree using `-r` is a good practice. > To make it read the first line literally, pass the flag `-r` to the > `read` builtin in the function `__git_eread`. > > Signed-off-by: Edwin Kofler > Signed-off-by: Koichi Murase Acked-by: Felipe Contreras -- Felipe Contreras