From: Tanushree Tumane via GitGitGadget Date: Sun, 24 Feb 2019 10:11:15 GMT Subject: [PATCH 01/26] bisect--helper: refer branch.buf before strbuf_release(...) Message-ID: <64117cde718f0d56ebfa4c30f4d8fe2155f5cf65.1551003074.git.gitgitgadget@gmail.com> In-Reply-To: From: Tanushree Tumane move `error("...%s...", branch.buf);` before `strbuf_release(&branch);`. add ' ' before "reset.." in error message. Mentored-by: Johannes Schindelin Mentored-by: Christian Couder Signed-off-by: Tanushree Tumane --- builtin/bisect--helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 22e669e3b1..e672ee9f18 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -169,11 +169,12 @@ static int bisect_reset(const char *commit) argv_array_pushl(&argv, "checkout", branch.buf, "--", NULL); if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) { + error(_("could not check out original" + " HEAD '%s'. Try 'git bisect" + " reset '."), branch.buf); strbuf_release(&branch); argv_array_clear(&argv); - return error(_("could not check out original" - " HEAD '%s'. Try 'git bisect" - "reset '."), branch.buf); + return -1; } argv_array_clear(&argv); } -- gitgitgadget