From: Josh Boyer <jwboyer@gmail.com>
Date: Wed, 17 Jan 2007 20:18:57 GMT
Subject: Re: [RFC] Add a suffix option to git-format-patch
Message-ID: <625fc13d0701171218i31585558wf89374eae9485341@mail.gmail.com>
In-Reply-To: <7vejptsglj.fsf@assigned-by-dhcp.cox.net>

On 1/17/07, Junio C Hamano <junkio@cox.net> wrote:
> David Kågedal <davidk@lysator.liu.se> writes:
>
> > "Josh Boyer" <jwboyer@gmail.com> writes:
> >
> >> I use git quite a bit to track my changes and then use
> >> git-format-patch to generate patches to send on to others.  For the
> >> most part, it works great but I find myself constantly doing:
> >>
> >> mv xxxx-foo.txt xxxx-foo.patch
> >
> > Seconded. I would even prefer .patch to be default, but I guess a
> > config parameter would help me there.
>
> Two minor objections to changing the default are: (1) it's a
> change and any change is bad ;-) and (2) the reason I changed it
> to .txt before submitting the original format-patch to Linus was
> because Emacs wanted to go into its "diff" mode when files are
> named with .patch suffix, which had two annoyances (read-only by
> default, and editing patch tried to automatically recount diff
> and its recounting screwed up in some cases I do not remember
> the details about).

Well there's your problem.  You're using Emacs.  ;)

Seriously though, I'll try and fix up the patch a bit soon and resubmit.

josh