From: Derrick Stolee <derrickstolee@github.com>
Date: Wed, 09 Mar 2022 19:21:07 GMT
Subject: Re: [PATCH 20/24] revisions API: clear "boundary_commits" in release_revisions()
Message-ID: <625c3868-60c9-009b-b01b-f186710d4d08@github.com>
In-Reply-To: <patch-20.24-fa53e81c7c0-20220309T123321Z-avarab@gmail.com>

On 3/9/2022 8:16 AM, Ævar Arnfjörð Bjarmason wrote:
> Clear the "boundary_commits" object_array in release_revisions(). This
> makes a *lot* of tests pass under SANITIZE=leak, including most of the
> t/t[0-9]*git-svn*.sh tests.
> 
> This includes the tests we had false-positive passes on before my
> 6798b08e848 (perl Git.pm: don't ignore signalled failure in
> _cmd_close(), 2022-02-01), now they pass for real.
> 
> Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to
> list those that don't pass than to touch most of those 66. So let's
> introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests
> won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true.

This paragraph perhaps belongs a few patches earlier in "revisions
API: have release_revisions() release "cmdline"", or else there was
some swap of order here.

Thanks,
-Stolee