From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Mon, 20 Aug 2012 13:52:02 GMT
Subject: Re: [PATCH/RFC v4 01/16] GSOC remote-svn
Message-ID: <6231669.WggyDX4Xa3@flomedio>
In-Reply-To: <7vzk5srm9w.fsf@alter.siamese.dyndns.org>

On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
> That indicates that one necessary patch to add logic to Makefile to
> go and build that subdirectory, at least before running the test,
> but possibly as part of the "all" target, is missing, isn't it?
> 
> Or you can add, at the beginning of your tests files that require
> the contrib bit, to have something like
> 
>         if test -e "$GIT_BUILD_DIR/remote-svn"
>         then
>                 test_set_prereq REMOTE_SVN
>         fi
> 
> and protect your tests with the prerequisite, e.g.
> 
>         test_expect_success REMOTE_SVN 'test svn:// URL' '
>                 ...
>         '
> 
> without changing the top-level Makefile.

What version would you prefer? Currently nothing in contrib/ is built by the 
toplevel Makefile..