From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 03 Jun 2025 21:15:54 GMT
Subject: Re: [PATCH v2] userdiff: add support for R programming language
Message-ID: <61ee9fac-303e-435d-ab0f-8338c23f2d5d@kdbg.org>
In-Reply-To: <xmqq8qm8k7p8.fsf@gitster.g>

Am 03.06.25 um 20:20 schrieb Junio C Hamano:
> Rodrigo Carvalho <rodrigorsdc@gmail.com> writes:
> 
>> The patch appends userdiff.c file in order to support R programming
>> language function header. This will be useful for those who use Git
>> for versioning .R files.
>>
>> Also, add three userdiff tests for R programming language
>> files. These files define simple function and nested function,
>> with and without indentation.
>>
>> Signed-off-by: Rodrigo Carvalho <rodrigorsdc@gmail.com>
>> ---
>> Changes in v2:
>> - Add support for function defined by '='
>> - Replace word regex to '[^ \t']
>> - Add new test that handles with nested function
> 
> Sorry, but this fell of the radar.
> 
> It seems all the reviewer comments on the previous round have been
> addressed.  If everybody is happy with this version, let's merge it
> down to 'next', for the next cycle.
> 
> Thanks.

Sorry for being slow. This round looks good to me, too.

-- Hannes