From: Felipe Contreras Date: Fri, 23 Jul 2021 19:32:40 GMT Subject: Re: [PATCH v3 0/5] Makefile: "make tags" fixes & cleanup Message-ID: <60fb1958b141b_1073e2089e@natae.notmuch> In-Reply-To: Jeff King wrote: > On Thu, Jul 22, 2021 at 01:23:01AM +0200, Ævar Arnfjörð Bjarmason wrote: > > > The big win here is that none of the tags targets depend on "FORCE" > > anymore, so we'll only re-generate them if our sources change. > > > > For v2, see > > https://lore.kernel.org/git/cover-0.5-0000000000-20210629T110837Z-avarab@gmail.com/ > > > > This fixes the series per feedback from Jeff King and Ramsay Jones, > > i.e: > > > > * In v2 the 3/5 broke things in a way that 4/5 fixed, that's now > > re-arranged and fixed. > > Thanks. Aside from some cscope appending arcana I found, these look good > to me. I have no opinion on "cscope*" versus "cscope.out", except that > it is not worth anybody's time to argue about. :) I agree with that as well. -- Felipe Contreras