From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 25 Jun 2021 18:32:39 GMT
Subject: RE: [PATCH v2 13/30] read-cache: convert post-index-change hook to use config
Message-ID: <60d62147d2661_cc8d2089d@natae.notmuch>
In-Reply-To: <patch-13.30-0300607a9b4-20210614T101920Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> From: Emily Shaffer <emilyshaffer@google.com>
> 
> By using hook.h instead of run-command.h to run, post-index-change hooks
> can now be specified in the config in addition to the hookdir.
> post-index-change is not run anywhere besides in read-cache.c.
> 
> This removes the last direct user of run_hook_ve(), so we can make the
> function static now. It'll be removed entirely soon.

This is mixing two logically independent changes. For the same reason I
suggested to split the run_hook_le() removal I think this should be
split too.

Not a big deal though, especially since the splitted patch would be very
small.

-- 
Felipe Contreras