From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Wed, 23 Jun 2021 19:25:59 GMT
Subject: RE: [PATCH 2/3] Makefile: fix "cscope" target to refer to cscope.out
Message-ID: <60d38ac74a93d_4290208ae@natae.notmuch>
In-Reply-To: <patch-2.3-ea39f1f5cd2-20210622T141844Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> --- a/Makefile
> +++ b/Makefile
> @@ -2737,10 +2737,11 @@ tags: FORCE
>  	$(FIND_SOURCE_FILES) | xargs ctags -a -o tags+ && \
>  	mv tags+ tags
>  
> +cscope.out:
> +	$(FIND_SOURCE_FILES) | xargs cscope -f$@ -b
> +
>  .PHONY: cscope
> -cscope:
> -	$(RM) cscope*
> -	$(FIND_SOURCE_FILES) | xargs cscope -b
> +cscope: cscope.out

The reason for the $(RM) removal is not explained in the commit message.

Otherwise the pach looks good to me.

-- 
Felipe Contreras