From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 18 Jun 2021 19:04:10 GMT
Subject: RE: [PATCH v2 01/45] completion: fix __git_cmd_idx regression
Message-ID: <60ccee2a48c07_ab0ea20894@natae.notmuch>
In-Reply-To: <20210618182518.697912-2-felipe.contreras@gmail.com>

Felipe Contreras wrote:
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -3511,7 +3511,7 @@ fi
>  
>  __git_func_wrap ()
>  {
> -	local cur words cword prev
> +	local cur words cword prev __git_cmd_idx=1

I just realized this isn't 100% correct thanks to Fabian Wermelinger.
If we use __git_complete then the index should be 0. The above fixes the
annoying errors, but some commands don't complete correctly (e.g.
git_fetch).

I've sent an updated fix [1].

[1] https://lore.kernel.org/git/20210618185832.700477-1-felipe.contreras@gmail.com/

-- 
Felipe Contreras