From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 13 Jun 2021 21:42:55 GMT
Subject: Re: [PATCH 1/4] test-lib-functions: introduce test_line_count_cmd
Message-ID: <60c67bdf5b77e_f569220858@natae.notmuch>
In-Reply-To: <3ab4f29e-987a-c7de-0cca-a64c3bf4be47@gmail.com>

Phillip Wood wrote:
> On 13/06/2021 14:28, Ævar Arnfjörð Bjarmason wrote:
> > 
> > On Sat, Jun 12 2021, Đoàn Trần Công Danh wrote:
> > 
> >> +	   { test "x$1" = "x!" && test $# = 1 ; }
> >> [...]
> >> +	if test "x$1" = "x!"
> > 
> > We don't use this test idiom in other places, it's OK to just use "$1" =
> > "!". I think we're past whatever portability concern made that popular
> > in some older shell code in the wild.
> 
> Slightly off topic but if anyone is interested in the history of this 
> test idiom and why it is no longer needed there is a good article at 
> https://www.vidarholen.net/contents/blog/?p=1035

Very nice! I often wondered why people did that.

-- 
Felipe Contreras