From: Felipe Contreras Date: Tue, 01 Jun 2021 23:40:44 GMT Subject: RE: [PATCH v4] contrib/completion: fix zsh completion regression from 59d85a2a05 Message-ID: <60b6c57c3cac1_4044208f@natae.notmuch> In-Reply-To: <20210601205229.46974-1-davvid@gmail.com> David Aguilar wrote: > A recent change to make git-completion.bash use $__git_cmd_idx > in more places broke a number of completions on zsh because it > modified __git_main but did not update __git_zsh_main. You might want to try this in the future to reference previous commits: % git show --quiet --format=reference 59d85a2a05 (git-completion.bash: use $__git_cmd_idx in more places, 2021-04-22) (one of the aliases I'm missing right now) > Suggested-by: Felipe Contreras > Signed-off-by: David Aguilar I have not tested this particular version, but I have tested similar changes, and this should work: Acked-by: Felipe Contreras -- Felipe Contreras