From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 31 May 2021 08:11:38 GMT
Subject: Re: [PATCH v2 6/6] doc: push: explain default=simple correctly
Message-ID: <60b49a3ae829b_24d28208fd@natae.notmuch>
In-Reply-To: <xmqqv96zwkl0.fsf@gitster.g>

Junio C Hamano wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > +If you are working on a centralized workflow (pushing to the same repository you
> > +pull from, which is typically `origin`), then you need to configure an upstream
> > +branch with the same name.
> 
> I suspect it would be simpler to read and easier to understand to
> bring the parethesized part front, e.g.
> 
>     If you are pushing to the same repository you pull from (which
>     is typically `origin`), then you need to ...
> 
> as it would avoid "the project is not centralized, but I push to my
> own repository and pull from it---what should I do?" questions.

The top of `push.default says:

  Different values are well-suited for specific workflows; for instance,
  in a purely central workflow (i.e. the fetch source is equal to the
  push destination), `upstream` is probably what you want.

We already brought up the central workflow, I think it's fine to reuse
the concept below.

-- 
Felipe Contreras