From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 28 May 2021 21:28:54 GMT
Subject: Re: [PATCH 04/11] push: simplify setup_push_simple()
Message-ID: <60b1609665443_2a371720853@natae.notmuch>
In-Reply-To: <CABPp-BG=496bZ78ToKK0vwmmtWDDC4qbCZfXbL+odzecy8U7vw@mail.gmail.com>

Elijah Newren wrote:
> On Fri, May 28, 2021 at 1:10 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > branch->refname can never be different from branch->merge[0]->src.
> 
> This statement isn't true without additional qualifications.  Perhaps
> extend your commit message with "...since the 'Additional safety'
> check dies if they differ." or some other wording that qualifies why
> it's true at the point of the code in question.

Will do. That in fact was in the back of my mind.

-- 
Felipe Contreras