From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 24 May 2021 18:45:33 GMT
Subject: Re: [PATCH v3 3/5] doc: remove unnecessary rm instances
Message-ID: <60abf44d9057d_1b20920861@natae.notmuch>
In-Reply-To: <60abf32038579_1b209208d2@natae.notmuch>

Felipe Contreras wrote:
> Junio C Hamano wrote:
> > Felipe Contreras <felipe.contreras@gmail.com> writes:

> > > Comments-by: Jeff King <peff@peff.net>
> > 
> > This is curious.  I understand what other kinds of trailers like
> > Helped-by and Suggested-by people sometimes use mean, but this one
> > does not tell anything other than that this person had some comments
> > on an earlier rounds, does not tell us what kind of comments they
> > were and if something was done to address those comments or the
> > comments were totally ignored or what.
> 
> If they were ignored they would not be part of the commit. It is
> understood the comments were incorporated.

Oh, and there are some instances already in the history:

7a9b0b802e (git-clean: add colors to interactive git-clean, 2013-06-25)
1b8fd46732 (git-clean: show items of del_list in columns, 2013-06-25)
52fd972d59 (git-completion: fix regression in zsh support, 2011-05-10)

Although one of those is mine.

Cheers.

-- 
Felipe Contreras