From: Felipe Contreras Date: Fri, 21 May 2021 17:43:38 GMT Subject: Re: [PATCH v4] help: colorize man pages Message-ID: <60a7f14a4f0ee_5503920867@natae.notmuch> In-Reply-To: <6dc0fcee-3415-e6f9-df30-c97de4385f56@gmail.com> Phillip Wood wrote: > On 20/05/2021 16:59, Felipe Contreras wrote: > > Phillip Wood wrote: > >> On 20/05/2021 14:58, Felipe Contreras wrote: > >>> That is true. We could add a check for that: > >>> > >>> if (getenv("LESS_TERMCAP_md")) > >>> return; > >>> > >>> However, it may not be necessary since many of the tips online set these > >>> variables inside a function. > >> > >> The only person who has tested this patch has reported a problem with > >> it, it seems unlikely that no other users will have similar issues. > > > > The check above will fix your problem, will it not? > > Yes it will if it is implemented which was not clear as your message > suggested it may not be necessary. It was a maybe. > I think it would be safer to check LESS_TERMCAP_{md,us,so} and not set > LESS if any of them are set as it is possible a user may only override > some of them. Sure, if we could set 6 variables before, we can check for 3 afterwards. -- Felipe Contreras