From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 13 May 2021 20:11:00 GMT
Subject: Re: [PATCH v6 11/11] test-lib: split up and deprecate test_create_repo()
Message-ID: <609d87d457433_80a220856@natae.notmuch>
In-Reply-To: <87eeeasumj.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> On Thu, May 13 2021, Felipe Contreras wrote:

> > Then it's not really deprecated; it's merely disfavored.
> >
> > To deprecate means to express disapproval of. If we are not going to
> > express disapproval (i.e. annoy the users of the test suite), then it's
> > not really deprecated. You can't eat your cake and have it too.
> >
> > I agree we shouldn't throw a warning right now, but at some point in the
> > future we should, *then* it will be deprecated.
> 
> I don't feel strongly about either term, as long as it's consistent.
> 
> I do think that "deprecated" is consistent in the way I'm using it
> within the git project. If you grep various things we've "deprecated" we
> usually just do so by noting so in the docs. In this case the docs are
> the comments in test-lib.sh.
> 
> We do also have things like git rebase --preserve-merges which emit a
> warning, but we use "deprecated" for both. By contrast we don't have a
> single git for "git grep -i disfavor".
> 
> Anyway, for now I'd prefer to just have this land as-is and sort out
> such minor things later, given the v6 and having two other topics
> waiting on this...

Fair enough.

-- 
Felipe Contreras