From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 13 May 2021 06:45:10 GMT
Subject: RE: [PATCH v6 11/11] test-lib: split up and deprecate test_create_repo()
Message-ID: <609ccaf67710b_3293208be@natae.notmuch>
In-Reply-To: <patch-11.11-217c5aed491-20210510T141055Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -1243,21 +1243,10 @@ test_atexit () {
>  		} && (exit \"\$eval_ret\"); eval_ret=\$?; $test_atexit_cleanup"
>  }
>  
> -# Most tests can use the created repository, but some may need to create more.
> +# Deprecated wrapper for "git init", use "git init" directly instead
>  # Usage: test_create_repo <directory>
>  test_create_repo () {

If this is deprecated why not add a warning?

  echo "warning: test_create_repo is deprecated in favor of git init" >&2

-- 
Felipe Contreras