From: Lessley Dennington Date: Tue, 07 Dec 2021 22:36:22 GMT Subject: Re: [PATCH 4/6] git-sparse-checkout.txt: update to document that set handles init Message-ID: <6032ba91-44ac-a165-8813-3576ac9857a5@gmail.com> In-Reply-To: On 12/7/21 1:13 PM, Elijah Newren wrote: > On Tue, Dec 7, 2021 at 12:42 PM Lessley Dennington > wrote: >> >> On 12/4/21 12:00 PM, Elijah Newren via GitGitGadget wrote: >>> From: Elijah Newren >>> > ... >>> ++ >>> +Historically, `set` did not used to handle all the necessary config >>> +settings, which meant that both `init` and `set` had to be called. >>> +Invoking both meant the `init` step would first remove nearly all >>> +tracked files (and in cone mode, ignored files too), then the `set` >>> +step would add many of the tracked files (but not ignored files) back. >>> +In addition to the lost files, the performance and UI of this >>> +combination was poor. >>> ++ >> Super nit: Perhaps update '`set` did not used to handle' to '`set` did not >> handle'. > > Yeah, that sounds better. I'll wait a bit longer for other comments, > then send a fix for this along with any other needed fixes (even if > just included Acks & Reviewed-bys I get). Thanks! > Sounds good. Also apologies that I didn't add this to v2 - my Thunderbird client hadn't loaded those messages at the time I sent my feedback.