From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 05 Feb 2021 07:58:42 GMT
Subject: Re: [PATCH v2 4/5] pager: properly log pager exit code when signalled
Message-ID: <5f5c5018-9fcc-6a9f-66fc-81d1c09946c3@kdbg.org>
In-Reply-To: <20210202020001.31601-5-avarab@gmail.com>

Am 02.02.21 um 03:00 schrieb Ævar Arnfjörð Bjarmason:
> When git invokes a pager that exits with non-zero the common case is
> that we'll already return the correct SIGPIPE failure from git itself,
> but the exit code logged in trace2 has always been incorrectly
> reported[1]. Fix that and log the correct exit code in the logs.

There's a more severe problem here, not with your patch, but with trace2
in general: it invokes async-signal-unsafe functions from a signal
handler, in particular, realloc, vsnprintf, gettimeofday, localtime_r
(and probably a lot more) via fn_child_exit_fl of trace2/tr2_tgt_normal.c

Is that something that we should care about?

-- Hannes