From: Jeff Hostetler Date: Thu, 24 Mar 2022 20:51:18 GMT Subject: Re: [PATCH v8 21/30] t7527: create test for fsmonitor--daemon Message-ID: <5f2bbcf3-fbaf-b1b4-7e53-b3f48cd971c2@jeffhostetler.com> In-Reply-To: <076201d83fc0$4a202140$de6063c0$@nexbridge.com> On 3/24/22 4:46 PM, rsbecker@nexbridge.com wrote: > On: March 24, 2022 4:43 PM, Jeff Hostetler wrote: >> On 3/24/22 4:36 PM, rsbecker@nexbridge.com wrote: >>> On March 24, 2022 4:28 PM, Jeff Hostetler wrote: >>>> On 3/24/22 3:05 PM, rsbecker@nexbridge.com wrote: >>>>> On March 24, 2022 3:00 PM, Junio C Hamano wrote: >>>>>> Subject: Re: [PATCH v8 21/30] t7527: create test for >>>>>> fsmonitor--daemon >>>>>> >>>>>> "Jeff Hostetler via GitGitGadget" writes: >>>>>> >>>>>>> From: Jeff Hostetler >>>> [...] >>>>> >>>>> May I request a bit of extra time on the -rc0 to -rc1 cycle for >>>>> this? I have a feeling >>>> that while testing this is probably going to go well, I would like to >>>> have a bit of extra time for anything that might come up. There are a >>>> lot of moving parts to this series. Not being critical, but debugging >>>> scripts on my platforms can be a bit rough at times. >>>>> >>>>> Thanks, >>>>> Randall >>>>> >>>> >>>> I'll simplify the `start_daemon()` function as Junio suggests, so >>>> hopefully that'll reduce the amount of debugging that you need. >>> Thanks. >>> >>>> BTW, which platforms are you worried about? >>> I'm worried about NonStop ia64 and x86. It's not just this series but also the >> fsync series. I think it's going to be a bit of a rid this time, but hoping not. >>> --Randall >>> >> >> I currently only have drivers/backends for Windows and MacOS for the builtin >> FSMonitor daemon feature. Since it relies on platform-specific code to read >> whatever filesystem journal or event stream that the the platform provides. >> >> So t7527 should do a skip_all on NonStop IIUC. > > I would have thought this was applicable to Linux also. So use, it should skip. Be in touch when if you do down that path. > --Randall > Sorry, yeah, I wanted to do a Linux version too, but there was just too much platform-specific stuff to juggle three different backends at the same time. I have the APIs in place between platform-specific and -independent code so that it shouldn't be hard to add a Linux version. I just didn't have the capacity to do all three (and the rest of $dayjob....) Jeff