From: Johannes Schindelin Date: Thu, 08 Oct 2015 19:15:36 GMT Subject: Re: [PATCH v3 2/2] pack-objects: do not get distracted by broken symrefs Message-ID: <5ee759ac37b2561eef9ab60d446ac463@dscho.org> In-Reply-To: Hi Junio, On 2015-10-07 19:45, Junio C Hamano wrote: > Johannes Schindelin writes: > >> It is quite possible for, say, a remote HEAD to become broken, e.g. >> when the default branch was renamed. >> >> We should still be able to pack our objects when such a thing happens; >> simply ignore broken symrefs (because they cannot matter for the packing >> process anyway). >> >> This fixes https://github.com/git-for-windows/git/issues/423 >> >> Signed-off-by: Johannes Schindelin >> --- > > It seems that the result of applying these two patches and log > messages of them are the same with what I queued on 'pu', except > that the first of these two patches adds a test with a wrong name > and then this one does "oops, that was misnamed". So I'll keep what > is already queued. Sorry for fixing up the wrong commit. I honestly meant to fix up the first one. And thank you for fixing it up in `pu` already; I should have known better and check first whether you fixed it. However, there was one more change I made: I wanted to have that link to https://github.com/git-for-windows/git/issues/423 in the commit message to better link the original report with the commit. Would yo kindly add the line This fixes https://github.com/git-for-windows/git/issues/423 before the Signed-off-by lines? Thanks, Dscho